Check for React presence when detecting WEBPACK_REACT type
#1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
commented
Aug 12, 2017
| (packageJson.dependencies && packageJson.dependencies.webpack)) && | ||
| ((packageJson.devDependencies && packageJson.devDependencies.react) || | ||
| (packageJson.dependencies && packageJson.dependencies.react)) | ||
| ) { |
There was a problem hiding this comment.
We should probably extract those checks into a function
ndelangen
approved these changes
Aug 18, 2017
Codecov Report
@@ Coverage Diff @@
## master #1646 +/- ##
=======================================
Coverage 20.87% 20.87%
=======================================
Files 251 251
Lines 5629 5629
Branches 675 690 +15
=======================================
Hits 1175 1175
+ Misses 3952 3926 -26
- Partials 502 528 +26
Continue to review full report at Codecov.
|
|
Merge when ready |
This was referenced Jan 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prevent incorrect detection when a vue project has webpack installed